-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: just a little bit of cleanup #9319
Conversation
❌ @paperdave 1 files with test failures on linux-x64: |
❌ @paperdave 1 files with test failures on linux-x64-baseline: |
❌ @paperdave 2 files with test failures on bun-darwin-aarch64:
|
❌ @paperdave 1 files with test failures on bun-darwin-x64: |
❌🪟 @paperdave, there are 15 test regressions on Windows x86_64
|
@@ -3278,7 +3278,7 @@ pub fn NewInterpreter(comptime EventLoopKind: JSC.EventLoopKind) type { | |||
const err = switch (this.state) { | |||
.expanding_redirect => this.state.expanding_redirect.expansion.state.err, | |||
.expanding_args => this.state.expanding_args.expansion.state.err, | |||
else => @panic("Invalid state"), | |||
else => |t| std.debug.panic("Unexpected state .{s} in Bun shell", .{@tagName(t)}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output.panic, we should ban std.debug.panic
@@ -6732,7 +6732,7 @@ pub fn NewInterpreter(comptime EventLoopKind: JSC.EventLoopKind) type { | |||
pub fn onAsyncTaskDone(this: *Rm, task: *ShellRmTask) void { | |||
var exec = &this.state.exec; | |||
const tasks_done = switch (exec.state) { | |||
.idle => @panic("Invalid state"), | |||
.idle => @panic("Unexpected state .idle in Bun shell 'rm' builtin."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
LGTM but @dylan-conway should look it over incase opinions about __has_install_script I feel like that name was deliberate |
The field should never be used directly was why it had double underscore, but there's also a comment saying this so LGTM |
Maybe we should rename it to @“#has_install_scripts” |
or we could keep the name |
No description provided.